Update REQUIRE, version, fixes for widen German esset

Project.toml

@@ -4,7 +4,7 @@ authors  = ["ScottPJones <[email protected]>"]
 keywords = ["Strings"]
 license  = "MIT"
 uuid     = "e79e7a6a-7bb1-5a4d-9d64-da657b06f53a"
-version  = "0.1.10"
+version  = "0.1.11"
 
 [deps]
 Pkg     = "44cfe95a-1eb2-52ea-b672-e2afdf69b78f"

REQUIRE

@@ -3,4 +3,4 @@ MurmurHash3 0.1.5
 ModuleInterfaceTools 0.1.6
 StrAPI 0.1.8
 CharSetEncodings 0.1.8
-ChrBase 0.1.6
+ChrBase 0.1.7

src/StrBase.jl

@@ -32,7 +32,7 @@ using ModuleInterfaceTools
              _memcmp, _memcpy, _memset, _fwd_memchr, _rev_memchr,
              empty_string, _calcpnt, _mask_bytes, _allocate,
              MS_UTF8, MS_UTF16, MS_UTF32, MS_SubUTF32, MS_Latin, MS_ByteStr, MS_RawUTF8,
-             _wrap_substr, _empty_sub, 
+             _wrap_substr, _empty_sub,
              AccessType, UInt16_U, UInt32_U, UInt16_S, UInt32_S, UInt16_US, UInt32_US,
              alignedtype, swappedtype, checkkeep, splitarr, __split, __rsplit, __replace
 

src/casefold.jl

@@ -6,16 +6,18 @@ Licensed under MIT License, see LICENSE.md
 =#
 
 _wide_lower_l(c) = ifelse(c > (V6_COMPAT ? 0xdf : 0xde), c != 0xf7, c == 0xb5)
+
 @inline _wide_lower_ch(ch) =
     ch <= 0x7f ? _islower_a(ch) : (ch > 0xff ? _islower_u(ch) : _wide_lower_l(ch))
 
 @inline _isupper_ch(ch) =
-    ch <= 0x7f ? _isupper_a(ch) : (ch <= 0xff ? _isupper_l(ch) : _isupper_u(ch))
+    ch <= 0x7f ? _isupper_a(ch) : (ch > 0xff ? _isupper_u(ch) : _isupper_l(ch))
 
-_wide_lower_latin(ch) = (ch == 0xb5) | (ch == 0xff) | (!V6_COMPAT & (ch == 0xdf))
+_wide_lower_latin(ch) = (ch == 0xb5) | (ch == 0xff) | (!V6_COMPAT && (ch == 0xdf))
 
 _wide_out_upper(ch) =
-    ifelse(ch == 0xb5, 0x39c, ifelse(ch == 0xff, 0x178, ifelse(ch == 0xdf, 0x1e9e, ch%UInt16)))
+    ifelse(ch == 0xb5, 0x39c,
+           ifelse(ch == 0xff, 0x178, ifelse(!V6_COMPAT && ch == 0xdf, 0x1e9e, ch%UInt16)))
 
 
 function uppercase_first(str::MaybeSub{S}) where {C<:ASCIICSE,S<:Str{C}}
@@ -357,7 +359,7 @@ function uppercase(str::MaybeSub{S}) where {C<:Union{UCS2_CSEs,UTF32_CSEs},S<:St
         pnt = beg = pointer(str)
         fin = beg + sizeof(str)
         while pnt < fin
-            _can_upper_ch(get_codeunit(pnt)) && return _upper(C, beg, pnt-beg, ncodeunits(str))
+            _wide_lower_ch(get_codeunit(pnt)) && return _upper(C, beg, pnt-beg, ncodeunits(str))
             pnt += sizeof(CU)
         end
         str

src/utf16case.jl

@@ -97,7 +97,7 @@ function uppercase(str::UTF16Str)
             prv = pnt
             (ch > 0xd7ff # May be surrogate pair
              ? _islower_u(ch > 0xdfff ? ch%UInt32 : get_supplementary(ch, get_codeunit(pnt += 2)))
-             : _can_upper_ch(ch)) &&
+             : _wide_lower_ch(ch)) &&
                  return _upper(UTF16Str, beg, prv-beg, ncodeunits(str))
             pnt += 2
         end

src/utf8case.jl

@@ -91,18 +91,22 @@ function _upper_utf8(beg, off, len)
             out += 1
         elseif ch < 0xc4
             ch = (ch << 6) | (get_codeunit(pnt += 1) & 0x3f)
-            if _can_upper_l(ch)
-                c16 = (ch - 0x20)%UInt16
-            elseif ch == 0xb5
-                c16 = 0x39c
-            elseif ch == 0xff
-                c16 = 0x178
-            elseif !V6_COMPAT && ch == 0xdf
-                c16 = 0x1e9e
+            if !V6_COMPAT && ch == 0xdf
+                # Increasing from 2 to 3 bytes, check to see if we need to resize
+                diff = (outend - out - 3) - (fin - pnt - 1)
+                if diff < 0
+                    outend -= diff
+                    resize!(buf, outend - out)
+                    out = pointer(buf)
+                    outend = out + sizeof(buf)
+                end
+                out = output_utf8_3byte!(out, 0x1e9e)
             else
-                c16 = ch%UInt16
+                out = output_utf8_2byte!(out, _can_upper_l(ch) ? (ch - 0x20)%UInt16
+                                              : ch == 0xb5 ? 0x39c
+                                              : ch == 0xff ? 0x178
+                                              : ch%UInt16)
             end
-            out = output_utf8_2byte!(out, c16)
         elseif ch < 0xe0
             # 2 byte
             c16 = get_utf8_2byte(pnt += 1, ch)

test/basic.jl

@@ -34,6 +34,28 @@ end
     end
 end
 
+@testset "casefold string" begin
+    for ST in (ASCIIStr, LatinStr, UCS2Str, UTF32Str, UTF8Str, UTF16Str)
+        C = eltype(ST)
+        tm = typemax(C)
+        for c = 0:Int(tm)
+            # Skip surrogates
+            0xd800 <= c < 0xe000 && continue
+            ch = C(c)
+            # Check to make sure this character would still fit uppercased
+            cu = uppercase(ch)
+            cu > tm && continue
+            for str in ("$ch test Beg", "test End $ch", "test $ch Mid", "$ch")
+                cvtstr = convert(ST, str)
+                @test uppercase(str) == uppercase(cvtstr)
+                @test lowercase(str) == lowercase(cvtstr)
+                @test titlecase(str) == titlecase(cvtstr)
+                @test uppercase_first(str) == uppercase_first(cvtstr)
+            end
+        end
+    end
+end
+
 @testset "{starts,ends}_with" begin
     for (ST, type_list) in compat_types, CT in type_list, str in test_strings_base[CT]
         cvtstr = convert(ST, str)