handle cartesian iteration inside for syntax

src/get_names_used.jl

@@ -114,12 +114,16 @@ function is_struct_type_param(leaf)
     end
 end
 
+# In the future, this may need an update for
+# https://github.com/JuliaLang/JuliaSyntax.jl/issues/432
 function in_for_argument_position(node)
     # We must be on the LHS of a `for` `equal`.
     if !has_parent(node, 2)
         return false
     elseif parents_match(node, (K"=", K"for"))
         return child_index(node) == 1
+    elseif parents_match(node, (K"=", K"cartesian_iterator", K"for"))
+        return child_index(node) == 1
     else
         return in_for_argument_position(get_parent(node))
     end

test/runtests.jl

@@ -95,7 +95,7 @@ end
 @testset "loops" begin
     cursor = TreeCursor(SyntaxNodeWrapper("test_mods.jl"))
     leaves = collect(Leaves(cursor))
-    @test map(get_val, filter(is_for_arg, leaves)) == [:i, :I, :j, :k]
+    @test map(get_val, filter(is_for_arg, leaves)) == [:i, :I, :j, :k, :k, :j, :xi, :yi]
 
     # Tests #35
     @test using_statement.(explicit_imports_nonrecursive(TestMod6, "test_mods.jl")) ==

test/test_mods.jl

@@ -53,7 +53,7 @@ Base.@kwdef struct Foo2
     qr::Int = 1
 end
 
-end # TestMOd5
+end # TestMod5
 
 module TestMod6
 
@@ -69,6 +69,12 @@ function foo(x)
     end
     for (; k) in x
     end
+
+    for (; k) in x, (; j) in y
+    end
+
+    for xi in x, yi in y
+    end
 end
 
 end # module