Promote multiple precise rvs to better common supertype#299
Merged
FriesischScott merged 3 commits intomasterfrom Feb 2, 2026
Merged
Promote multiple precise rvs to better common supertype#299FriesischScott merged 3 commits intomasterfrom
FriesischScott merged 3 commits intomasterfrom
Conversation
FriesischScott
had a problem deploying
to
pr-299
GitHub Actions
Failure
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
lukasfritsch
approved these changes
Feb 2, 2026
Member
lukasfritsch
left a comment
lukasfritsch
left a comment
There was a problem hiding this comment.
Looks good now, works for TMCMC, MAP and MLE and doesn't work when one of the input RVs is a p-box (as it should).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR overloads
promote_rulefor any twoRandomVariables{<:UnivariateDistribution}such that the common type is not simplyRandomVariablebutRandomVariable{<:UnivariateDistribution}.This allows to better dispatch on a vector of precise random variables where no
ProbabilityBoxis present.Closes #298