Skip to content

Conversation

@lucianchauvin
Copy link
Contributor

@lucianchauvin lucianchauvin commented Jul 2, 2025

Not sure if this is the best way to go about this. Let me know if I should move some stuff around and/or change the defaults. refs #315

@lucianchauvin lucianchauvin changed the title Add in fractional width/height and change default as per refs: 315 Add in fractional width/height and change default as per #315 Jul 2, 2025
@Julian
Copy link
Owner

Julian commented Jul 3, 2025

Seems to work great, well done. Can you add another test for these fractional cases, you should be able to manipulate vim.o.lines I think before opening the infoview.

The CI flakiness on macOS is unfortunately still not fixed until I remove the Mathlib dependency somehow, but the pre-commit failures are real: https://results.pre-commit.ci/run/github/325645198/1751495304.Pg-zXgoRT0aWUrWJDcKMYg (and telling you you need local function res_dim.)

@Julian
Copy link
Owner

Julian commented Jul 15, 2025

Hey @lucianchauvin the CI flakiness should be resolved if you merge main, lemme know if you're still interested in adding the test!

@lucianchauvin
Copy link
Contributor Author

Hey @lucianchauvin the CI flakiness should be resolved if you merge main, lemme know if you're still interested in adding the test!

I've fixed the issue that the pipeline caught. For the tests, would you like me to just add two:

  • one that opens the infoview horizontally and checks that its lines correspond to the percent
  • another one for vertical with columns

@Julian
Copy link
Owner

Julian commented Jul 17, 2025

would you like me to just add two

Yeah those two sound perfect to me!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants