Use correct version for SOAP replies. #317
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Well that is handy, the existing test for serverlib - testContentTypeParsing is currently making a SOAP 1.2 request and expecting a SOAP 1.1 reply. Looks like most of my work in writing a unit test is already done. |
dfaure-kdab
reviewed
Jun 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've been sitting on this patch for 9 years.
Essentially no matter the incoming version of the SOAP request to KDSoapServer, it always replies with a SOAP 1.1 message body.
This stores the incoming SOAP version to ensure the reply uses the correct SOAP version.
I'll look at doing some unit tests for it, although after nearly a decade I know it works.