Conversation
lievenhey
force-pushed
the
complex-search
branch
2 times, most recently
from
61eeef7 to
a1fe6f0
Compare
Contributor
|
That's a nice implementation! The tooltip also helps for documentation purposes (I'm still not sure if there should be a note on that in the README as well). |
milianw
requested changes
Sep 26, 2024
lievenhey
force-pushed
the
complex-search
branch
from
a1fe6f0 to
593437c
Compare
GitMensch
reviewed
Oct 10, 2024
lievenhey
force-pushed
the
complex-search
branch
from
593437c to
11834c4
Compare
Since we use QSortFilterProxyModel we get this for free. This patch adds support for regex search by not escaping the search term if it is prefix with %. For the flamegraph there is a custom implementation, which changes the current QString::contains to a QRegularExpression::match call. Closes: #666
lievenhey
force-pushed
the
complex-search
branch
from
11834c4 to
888c1bc
Compare
lievenhey
commented
Oct 10, 2024
| { | ||
| SearchResults result; | ||
| if (searchValue.isEmpty()) { | ||
| if (expression.pattern().isEmpty()) { |
Contributor
Author
There was a problem hiding this comment.
I'm not sure if this should be !expression.isValid() || expression.pattern().isEmpty()
Contributor
There was a problem hiding this comment.
if it isn't valid we should not get here, at least not when executed from the UI (the function could possibly assert that or do an early-exit for the invalid expression)
milianw
reviewed
Nov 18, 2024
| { | ||
| SearchResults result; | ||
| if (searchValue.isEmpty()) { | ||
| if (expression.pattern().isEmpty()) { |
Collaborator
|
otherwise code lgtm, tests would obviously be nice to have, but I don't think we have any integration tests of that sort yet :( |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since we use QSortFilterProxyModel we get this for free. This patch adds support for regex search by not escaping the search term if it is prefix with %.
For the flamegraph there is a custom implementation, which changes the current QString::contains to a QRegularExpression::match call.
Closes: #666