Code optimization, especially toggling section #266
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We don't need to do anything if we can't log, so bypass the logger entirely. Also bypass a copy of the file during TextDocument::text(), as it's not something the user will do.
narnaud
changed the title
added 2 commits
September 25, 2025 14:14
No need to get the text from the document every time, this reduce the complexity a lot. Also squeeze the text from the range, to avoid using too much memory (as the string is the size of the file).
This is faster than getting all the symbols, as we don't need to do any kind of processing of the symbols.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
perf: Use a query for toggling section
perf: Optimize symbols creation
perf: Bypass logger if it's not needed