Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix link to download mpir 3.0.0 #60

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

gutjuri
Copy link

@gutjuri gutjuri commented Sep 6, 2023

Unfortunately, the url mpir[.]org now redirects to a malaysian gambling website. I have updated the documentation to instruct the user to instead download mpir from github (https://github.com/wbhart/mpir).

In order for the installation process to work, one now has to install four additional packages (at least on ubuntu).

@NigelSmart
Copy link
Contributor

NigelSmart commented Sep 6, 2023 via email

@gutjuri
Copy link
Author

gutjuri commented Sep 6, 2023

Thanks for your reply. I respect this decision, however, I think you should consider making one exception to this rule and merge this PR. Even though SCALE-MAMBA is no longer actively maintained, it is still used in research and teaching. Currently, the docs link to a sketchy gambling website (mpir[.]org). I think that this has the potential become a security risk, as nothing stops mpir[.]org from starting to serve malware, which the user will then happily compile and run by following the installation instructions.

I have already updated the docs as to acquire the mpir dependency through GitHub. I have tested that compilation still works. I hope this does not cause you much work, if there's anything else I can to I'd be happy to do so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants