Make GitHub actions report config + python tests better #644
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- CI builds no longer build a docker image - They use the latest danger-klippers image, but override /klipper - Firmware build tests are done by running them one at a time, with github actions showing the grouping in the output to make it easy to see what failed. - Python tests are done using a matrix
vvuk
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CI builds were running tests by building a single docker image. This was both slow and very difficult to understand what failed. This PR does the following:
github actions showing the grouping in the output to make it easy
to see what failed.
I had a variant of this that split every config test into its own job, but that meant that every job had to pull the docker image which took too much time. This is good enough IMO:
./scripts/ci-build.shcan also be improved to allow running e.g../scripts/ci-build.sh compile rp2040locally to make it easier to reproduce things; right now it makes some assumptions about running on ci, but would be an easy fix (for later, I think). ... and as I typed that out, that could basically be the start of a user-visible "compile for this board" command?