[WIP][TE-7347] Upgrade rails admin to latest version #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update leftover references to Travis CI
Enable rubocop-performance
This fixes an issue where boolean form fields did not render correctly due to the active and status classes being incorrectly applied to the field as an array.
💚 Add CodeQL to CI
- Use `yarn run`, instead of `./node_modules/.bin/` - Remove unnecessary .prettierignore entries - Address Rubocop Performance/RegexpMatch offense in the PR build - Apply async: true to javascript tags - Restore order changes in gemfiles/* - Change scripts task `prettier` to `format`, since it conflicts with the prettier command itself - Apply prettier to src/rails_admin/styles/themes/cerulean
Webpacker support
Was able to reproduce failure using the seed of a CI run (https://github.com/codealchemy/rails_admin/runs/4543403935?check_suite_focus=true) ` bundle exec appraisal rails-7.0 rspec --seed 47623 --bisect` produces Bisect complete! Reduced necessary non-failing examples from 996 to 0 in 2.9 seconds. The minimal reproduction command is: rspec './spec/integration/fields/multiple_carrierwave_spec.rb[1:1]' --seed 47623 Adding `js: true` to the spec block resolved failures for that seed, which did not return when running the full suite
…carrierwave Fix flakey MultipleCarrierwave field spec
…has_one and has_many Fixes railsadminteam#2585
Co-authored-by: Mitsuhiro Shibuya <[email protected]>
…am#3689) Previously, the post_install_message contained trailing whitespace on its last line such that the user's console prompt would be shifted to the right in an unusual way. Now, follow shell conventions and finish the message with the a final newline and nothing else. This change also left aligns the message like other Ruby gem post_install_messages do. Before: ``` $ bundle install ... Post-install message from rails_admin: ### Upgrading RailsAdmin from 2.x.x to 3.x.x ### Due to introduction of Webpack/Webpacker support, some additional dependencies and configuration will be needed. Running `bin/rails g rails_admin:install` will suggest required changes, based on the current setup of your app. For a complete list of changes, see https://github.com/railsadminteam/rails_admin/blob/master/CHANGELOG.md jon@localhost$ ``` After: ``` \### Upgrading RailsAdmin from 2.x.x to 3.x.x ### Due to introduction of Webpack/Webpacker support, some additional dependencies and configuration will be needed. Running `bin/rails g rails_admin:install` will suggest required changes, based on the current setup of your app. For a complete list of changes, see https://github.com/railsadminteam/rails_admin/blob/master/CHANGELOG.md Successfully installed rails_admin-3.1.2 jon@localhost$ ```
- Add a spec - Apply Prettier
…ailsadminteam#3656) * Show a thumbnail of all representable Active Storage files not only images * Fix RuboCop offense * Show representable and all images (incl. SVGs) * Fix RuboCop offense
- Do not abbreviate 'representation' - Add specs
tim-luong-goldenowl
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.