[TE-7348] Upgrade rails admin to latest version 3.2.0 #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…has_one and has_many Fixes railsadminteam#2585
Co-authored-by: Mitsuhiro Shibuya <[email protected]>
…railsadminteam#3455) * Upgrade Bootstrap to 5.1.3 Closes railsadminteam#3083 * Upgrade vendored Bootstrap as well Also removed old theming functionality, since existing ones are not compatible with Bootstrap 5 * Migrate datetimepicker widget to flatpickr * Reflect review and minor fix - Fix inconsistent breakpoint - Remove debug stuffs * Apply form-control-sm to make datepicker field have the same size with other inputs Co-authored-by: Alex Schmitt <[email protected]> * Reflect review suggetions - Prevent `true` showing up as a css class - form-control-sm must come with form-control: https://getbootstrap.com/docs/5.1/forms/form-control/#sizing - btn-small didn't have any effect - Fix action menu having too narrow gap between icon and text * Fix invalid closing tag </input> * Update styles in Export and History action * Fix spec issue, with removing the workaround https://github.com/railsadminteam/rails_admin/runs/4747523252?check_suite_focus=true * Add additional datetime format used somewhere in rails-i18n * ProvidePlugin is no longer necessary since all JS dependencies are ES module ready now Co-authored-by: Alex Schmitt <[email protected]>
* Remove JavaScript library jquery-pjax The library is no longer maintained and has not received a new release since May 20, 2017. See https://github.com/defunkt/jquery-pjax > Status of this project > > jquery-pjax is largely unmaintained at this point. This also removes the Ruby gem rack-pjax which is also no longer maintained and has not received a new release since Mar 24, 2019. This is work towards the goal of dropping jQuery in favor of more vanilla JavaScript solutions. As a dependency using jQuery, pjax was a barrier toward this goal. jquery-pjax was originally introduced in 645d678 (Nov 16, 2011). Presumably as a page loading optimization, however it is not strictly necessary to achieve the set of RailsAdmin features. After many years of improvements in browser caching, loading, and JavaScript evaluation it is unclear if this optimization is still necessary for a good UX. Refs railsadminteam#2893
…railsadminteam#3407) Co-authored-by: Mitsuhiro Shibuya <[email protected]>
- Add a spec - Apply Prettier
…ailsadminteam#3656) * Show a thumbnail of all representable Active Storage files not only images * Fix RuboCop offense * Show representable and all images (incl. SVGs) * Fix RuboCop offense
- Do not abbreviate 'representation' - Add specs
tim-luong-goldenowl
force-pushed
the
feature/TE-7348
branch
from
b0b12fd to
9975e9a
Compare
ValidationChanges verified under https://kaligo.atlassian.net/browse/TE-7348 Impact: Only Reference in HG updated |
jperdiguerra
approved these changes
Nov 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.