Fix memory leak by replacing @lru_cache with instance-level caching in data parsers #724
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Replace
@lru_cacheon instance methods with instance-level caching to fix memory leak. The global LRU cache keys byself, retaining parser instances and their DataFrames indefinitely.What's Changed
_field_metas_cache,_raw_fields_cache,_cache_lockfor thread-safe instance-level caching with double-checked locking.@lru_cacheonly for pure functionget_timezone_base_offset.Behavior Compatibility
@lru_cacheautomatically addscache_info()andcache_clear()methods to decorated functions. This project does not use these methods internally, but external code that explicitly calls them will raiseAttributeErrorafter this change (e.g.,BaseDataFrameDataParser.field_metas.fget.cache_clear()).Breaking Changes
None for normal usage. Only affects code introspecting or manipulating the LRU cache internals.
Related Issues
Fixes #723