Update plugin for NetBox 4.3.0 compatibility #87
Conversation
- Added support for NetBox 4.3.0 in the compatibility table in README.md. - Updated `min_version` and `max_version` in `netbox_attachments/__init__.py` to reflect compatibility with NetBox 4.3.0. - Bumped plugin version to 8.0.0 in `netbox_attachments/version.py`.
WalkthroughThe changes update the plugin to support NetBox version 4.3.x. The README compatibility table now includes NetBox 4.3.0 and plugin version 8.x.x. The plugin configuration in Changes
Assessment against linked issues
Poem
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (3)
README.md(1 hunks)netbox_attachments/__init__.py(1 hunks)netbox_attachments/version.py(1 hunks)
🔇 Additional comments (2)
netbox_attachments/version.py (1)
1-1: Bump plugin version to 8.0.0.The version string has been correctly updated to reflect the new major release. Ensure your release notes and CI/CD pipelines reference this new version.
README.md (1)
27-27: Add NetBox 4.3.0 compatibility entry.The compatibility table now includes NetBox >= 4.3.0 with plugin version 8.x.x, matching the code changes. Verify that the rows remain in ascending NetBox version order for clarity.
| min_version = "4.3.0" | ||
| max_version = "4.3.99" |
There was a problem hiding this comment.
💡 Verification agent
🧩 Analysis chain
Update NetBox version constraints to 4.3.x.
The min_version and max_version settings have been adjusted to support NetBox 4.3.0–4.3.99, in line with the new plugin release. Please confirm there are no remaining references to the old 4.2.x range elsewhere in the repository.
🏁 Script executed:
#!/bin/bash
# Verify no leftover references to NetBox 4.2.x constraints
rg -n '4\.2\.' --no-colorLength of output: 467
🏁 Script executed:
#!/bin/bash
# Re-verify no leftover references to NetBox 4.2.x constraints without invalid flags
rg -n '4\.2\.' .Length of output: 188
Update compatibility matrix to NetBox 4.3.x
We’ve updated min_version/max_version to support NetBox 4.3.0–4.3.99, but there’s still a leftover reference to 4.2.x in the docs. Please address the following:
• README.md (line 26): update the compatibility table entry from “>= 4.2.0” to “>= 4.3.0”
• (Optional) The migration header # Generated by Django 4.2.4… in netbox_attachments/migrations/0005_netboxattachment_description.py refers to the Django generator version and can remain unchanged.
Closes #86
min_versionandmax_versioninnetbox_attachments/__init__.pyto reflect compatibility with NetBox 4.3.0.netbox_attachments/version.py.Summary by CodeRabbit