forked from idaholab/MontePy
-
Notifications
You must be signed in to change notification settings - Fork 0
Fixed failing tests for #830 #1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
MicahGale
wants to merge
6
commits into
Kaos599:develop
Choose a base branch
from
MicahGale:imp_default_fix
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+25
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 1b5b8b4. In added back the tests the tests were over jealously changed. These changes broke the rube golderg machine of this tests.
Author
|
Testing results: |
Author
|
@Kaos599 just wanted to check in if you are able to check on this. |
Owner
Hey, i will try picking this up by this weekend. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist for MontePy
Description
This is a small PR for supporting idaholab#830, and fixing the failing tests. There were three failing tests. I found that:
tests.test_integration.test_read_write_cycledue to the test accidentally being changed.tests/test_universe_integration.pyassuming that the cells used would always printimp:n=1, which is no longer the case, so I fixed that assumption.General Checklist
blackversion 25.LLM Disclosure
Were any large language models (LLM or "AI") used in to generate any of this code?
Documentation Checklist
First-Time Contributor Checklist
pyproject.tomlif you wish to do so.Additional Notes for Reviewers
Ensure that: