Skip to content

Conversation

@MicahGale
Copy link

Pull Request Checklist for MontePy

Description

This is a small PR for supporting idaholab#830, and fixing the failing tests. There were three failing tests. I found that:

  • Two of the failing tests were from tests.test_integration.test_read_write_cycle due to the test accidentally being changed.
  • The final failure was due a test in tests/test_universe_integration.py assuming that the cells used would always print imp:n=1, which is no longer the case, so I fixed that assumption.

General Checklist

  • I have performed a self-review of my own code.
  • The code follows the standards outlined in the development documentation.
  • I have formatted my code with black version 25.
  • I have added tests that prove my fix is effective or that my feature works (if applicable).

LLM Disclosure

Were any large language models (LLM or "AI") used in to generate any of this code?

  • Yes
    • Model(s) used:
  • No

Documentation Checklist

  • I have documented all added classes and methods.
  • For infrastructure updates, I have updated the developer's guide.
  • For significant new features, I have added a section to the getting started guide.

First-Time Contributor Checklist

  • If this is your first contribution, add yourself to pyproject.toml if you wish to do so.

Additional Notes for Reviewers

Ensure that:

  • This PR fully addresses and resolves the referenced issue(s).
  • The submitted code is consistent with the merge checklist outlined here.
  • The PR covers all relevant aspects according to the development guidelines.
  • 100% coverage of the patch is achieved, or justification for a variance is given.

@MicahGale
Copy link
Author

Testing results:

==================================================================================================== test session starts =====================================================================================================
platform linux -- Python 3.13.5, pytest-8.4.1, pluggy-1.6.0
rootdir: /home/mgale/dev/montepy
configfile: pyproject.toml
testpaths: tests
plugins: hypothesis-6.138.8, profiling-1.8.1
collected 942 items                                                                                                                                                                                                          

tests/test_cell_problem.py ...........................                                                                                                                                                                 [  2%]
tests/test_data_inputs.py ........................                                                                                                                                                                     [  5%]
tests/test_edge_cases.py ........................                                                                                                                                                                      [  7%]
tests/test_errors.py ..                                                                                                                                                                                                [  8%]
tests/test_geom_integration.py ...                                                                                                                                                                                     [  8%]
tests/test_geometry.py ........................                                                                                                                                                                        [ 11%]
tests/test_importance.py .........................                                                                                                                                                                     [ 13%]
tests/test_input_file.py .......                                                                                                                                                                                       [ 14%]
tests/test_integration.py ...............................................................................................                                                                                              [ 24%]
tests/test_interface.py ..................                                                                                                                                                                             [ 26%]
tests/test_main.py ....................................                                                                                                                                                                [ 30%]
tests/test_material.py ............................................................................................................                                                                                    [ 41%]
tests/test_mcnp_problem.py .....                                                                                                                                                                                       [ 42%]
tests/test_mode.py ......                                                                                                                                                                                              [ 42%]
tests/test_nuclide.py .....................................................................                                                                                                                            [ 50%]
tests/test_numbered_collection.py ..............................................................................................                                                                                       [ 60%]
tests/test_numbers.py ...                                                                                                                                                                                              [ 60%]
tests/test_scripts.py ..                                                                                                                                                                                               [ 60%]
tests/test_source.py .                                                                                                                                                                                                 [ 60%]
tests/test_source_def.py ...                                                                                                                                                                                           [ 61%]
tests/test_surfaces.py .....................................                                                                                                                                                           [ 65%]
tests/test_syntax_parsing.py ......................................................................................................................................................................................... [ 84%]
.................................................                                                                                                                                                                      [ 89%]
tests/test_tally.py ................                                                                                                                                                                                   [ 91%]
tests/test_transform.py ..........................                                                                                                                                                                     [ 94%]
tests/test_universe.py ....................................                                                                                                                                                            [ 98%]
tests/test_universe_integration.py ........                                                                                                                                                                            [ 99%]
tests/test_utilities.py ........                                                                                                                                                                                       [ 99%]
tests/test_version.py .                                                                                                                                                                                                [100%]

==================================================================================================== 942 passed in 22.26s ====================================================================================================
(montepy) 

@MicahGale
Copy link
Author

MicahGale commented Nov 12, 2025

@Kaos599 just wanted to check in if you are able to check on this.

@Kaos599
Copy link
Owner

Kaos599 commented Nov 15, 2025

@Kaos599 just wanted to check in if you are able to check on this.

Hey, i will try picking this up by this weekend.
I will let you know how it goes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants