Fixed CSS for publisher flipper #3461
Open
+19
−13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Just to let you know, I'm still planning to merge this in. Just not yet ready to do the testing to see if the width issue will be impactful. |
|
@MrRobotjs since you like CSS, could you look into this PR and see if you can remove the one constraint that's holding me from merging in (aka the width issue)? |
|
I tested this and images that have a longer width are still square. I think the proper fix would be to do what @therobbiedavis proposed here #3451 (comment) , i was already implementing this but I tried the idea of only showing the text and on hover a tooltip with the image will appear above instead. But I can also just make it so only the image appears if available or text if no image is available. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed
As mentioned on Discord, one caveat is that the width will be based upon the first publisher.