Skip to content

Card checkbox style updates #3780

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 7 commits into
base: develop
Choose a base branch
from

Conversation

MrRobotjs
Copy link
Contributor

@MrRobotjs MrRobotjs commented May 1, 2025

Changed

  • Changed: Changed bulk operations style while improving sizing for smaller screens
  • Changed: Changed card checkboxes style

Fixed

  • Fixed: Fixed zoom in when launching PWA by setting a 1rem to search bar input

Theme

  • Added: Added --text-light-muted-color variable to dark.scss

firefox_HLyyoDzp6B

firefox_3jNdQGyDfM

MrRobotjs added 4 commits May 1, 2025 01:11
- changed border-radius to 50% for a circle
- transparent bg to dark opaque
- added bg color to read/unread/action buttons
- "items selected" text color now uses the primary color variable and reduced font size
- "deselect all" text uses light muted color variable, goes to white on hover and reduced font size
- added border all around to bulk operations box
- added 2px padding to bulk operations box
- input font size changed to 1rem

PWA's zoom in on input fields that are less than 16px.
@MrRobotjs MrRobotjs changed the title Feature/qol bulk operations style changes Feature/qol bulk operations and card checkboxes style changes May 1, 2025
@Fesaa
Copy link
Collaborator

Fesaa commented May 4, 2025

I cherry-picked the PWA zoom-in fix locally to try it out. This is the behaviour I saw on my iPhone;

If I opened the PWA while already being logged in, I'm never seeing the zoom-in.
If I opened the PWA on the login screen, I sometimes do see the zoom-in after logging in.

I think doing your fix but for the login inputs screen may fix this?

@MrRobotjs
Copy link
Contributor Author

I cherry-picked the PWA zoom-in fix locally to try it out. This is the behaviour I saw on my iPhone;

If I opened the PWA while already being logged in, I'm never seeing the zoom-in. If I opened the PWA on the login screen, I sometimes do see the zoom-in after logging in.

I think doing your fix but for the login inputs screen may fix this?

I just tried it and you are right. I completely forgot about the login screen. To be honest, pretty much every input that isn’t 16px or larger is going to have that zoom in effect. But we could test it out on login/search input fields first to see if it actually fixes it.

Copy link

@majora2007
Copy link
Member

@MrRobotjs just following up on Fessa's ask, any updates?

@majora2007 majora2007 changed the title Feature/qol bulk operations and card checkboxes style changes Card checkbox style updates Jun 2, 2025
@majora2007
Copy link
Member

From testing:

  • I noticed there is some lag when you move hover off a card, the overlay dissipates, but the checkbox stays a bit longer.
    lag-effect

  • You changed the read button design, please revert it back to a circle.

While we are touching this code, it would be great to hide the READ button when we are in selection mode, as it is very unlikely you are trying to read anything in bulk selection mode.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

3 participants