ci: add starklings evaluation #20
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ijusttookadnatest
force-pushed
the
main
branch
2 times, most recently
from
5e6f598 to
89539b7
Compare
enitrat
reviewed
Jul 12, 2025
| LANGSMITH_TRACING=true | ||
| LANGSMITH_ENDPOINT="https://api.smith.langchain.com" | ||
| LANGSMITH_API_KEY="<your-api-key>" | ||
| LANGCHAIN_TRACING=true |
Collaborator
There was a problem hiding this comment.
should stay LANGSMITH no? they're not intrinsicly coupled
enitrat
reviewed
Jul 12, 2025
| pages: BookPageDto[], | ||
| ): Promise<Document<BookChunk>[]> { | ||
| return super.createChunks(pages, false); | ||
| return super.createChunks(pages, true); |
Collaborator
There was a problem hiding this comment.
is it still broken if we don't split the pages?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.