Fixes #38270 - Don't create content view environment when CV is not published to LCE

Author: jeremylenz

app/lib/katello/errors.rb

@@ -14,6 +14,8 @@ class InvalidRepositoryTypeError < StandardError; end
 
     class MultiEnvironmentNotSupportedError < StandardError; end
 
+    class ContentViewEnvironmentError < StandardError; end
+
     # unauthorized access
     class SecurityViolation < StandardError; end
 

app/models/katello/content_view_environment.rb

@@ -21,6 +21,7 @@ class ContentViewEnvironment < Katello::Model
     validates_lengths_from_database
     validates :environment_id, uniqueness: {scope: :content_view_id}, presence: true
     validates :content_view_id, presence: true
+    validates :content_view_version_id, presence: true
     validates_with Validators::ContentViewEnvironmentOrgValidator
     validates_with Validators::ContentViewEnvironmentCoherentDefaultValidator
 

app/models/katello/host/content_facet.rb

@@ -149,6 +149,7 @@ def content_view_environment_labels
       end
 
       # rubocop:disable Metrics/CyclomaticComplexity
+      # rubocop:disable Metrics/PerceivedComplexity
       def assign_single_environment(
         content_view_id: nil, lifecycle_environment_id: nil, environment_id: nil,
         content_view: nil, lifecycle_environment: nil, environment: nil
@@ -165,11 +166,15 @@ def assign_single_environment(
         end
 
         content_view_environment = ::Katello::ContentViewEnvironment
-          .where(:content_view_id => content_view_id, :environment_id => lifecycle_environment_id)
-          .first_or_create do |cve|
-          Rails.logger.info("ContentViewEnvironment not found for content view '#{cve.content_view_name}' and environment '#{cve.environment&.name}'; creating a new one.")
+          .find_by(:content_view_id => content_view_id, :environment_id => lifecycle_environment_id)
+        if content_view_environment.nil?
+          cv_name = ::Katello::ContentView.find_by(:id => content_view_id)&.name
+          fail ::Katello::Errors::ContentViewEnvironmentError, _("Unable to find a content view with ID %s") % content_view_id if cv_name.nil?
+          env_name = ::Katello::KTEnvironment.find_by(:id => lifecycle_environment_id)&.name
+          fail ::Katello::Errors::ContentViewEnvironmentError, _("Unable to find a lifecycle environment with ID %s") % lifecycle_environment_id if env_name.nil?
+          hypothetical_cve_label = "%s/%s" % [env_name, cv_name]
+          fail ::Katello::Errors::ContentViewEnvironmentError, _("Cannot assign content view environment %s: The content view has either not been published or has not been promoted to that lifecycle environment.") % hypothetical_cve_label
         end
-        fail _("Unable to create ContentViewEnvironment. Check the logs for more information.") if content_view_environment.nil?
 
         self.content_view_environments = [content_view_environment]
       end