Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #38323 - Add test cases to host details cards #11356

Merged
merged 1 commit into from
Apr 8, 2025

Conversation

lfu
Copy link
Member

@lfu lfu commented Mar 28, 2025

What are the changes introduced in this pull request?

Remove isExpandedGlobal from ImageModeCard, HwPropertiesCard and InstalledProductsCard.
Add test cases to these cards.

Depends on theforeman/foreman#10504.

Considerations taken when implementing this change?

CardTemplate does not have isExpandedGlobal as argument.

What are the testing steps for this pull request?

npx jest webpack/components/extensions/HostDetails/DetailsTabCards/__test__

@lfu lfu force-pushed the test_image_mode_card branch 2 times, most recently from 4807ae4 to 4374b11 Compare March 31, 2025 14:43
@lfu lfu force-pushed the test_image_mode_card branch 2 times, most recently from 8fc985a to accf517 Compare March 31, 2025 16:58
Copy link
Member

@ianballou ianballou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The test passes locally for me and the image mode card still looks normal 👍

Let's wait to merge until the Foreman change gets in and the test passes here.

@lfu lfu force-pushed the test_image_mode_card branch from accf517 to bde9688 Compare April 7, 2025 14:06
@lfu lfu changed the title Fixes #38323 - Add test cases to image mode card Fixes #38323 - Add test cases to host details cards Apr 7, 2025
@lfu lfu force-pushed the test_image_mode_card branch from bde9688 to d5413a8 Compare April 7, 2025 16:18
Copy link
Member

@ianballou ianballou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All set!

@lfu lfu merged commit 1c4e1cf into Katello:master Apr 8, 2025
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants