-
Notifications
You must be signed in to change notification settings - Fork 334
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(tests/e2e-evm): Restructure ABI tests for extensibility & reduce duplication #2031
Open
drklee3
wants to merge
11
commits into
nd-implement-basic-precompile-calling
Choose a base branch
from
dl-e2e-abi-tests-refactor
base: nd-implement-basic-precompile-calling
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+760
−506
Open
Changes from 1 commit
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
dd9b489
refactor: Initial restructure of ABI basic function tests
drklee3 5737b3b
refactor: Restructure of ABI fallback tests
drklee3 b184907
fix: Use separate shouldRun fn signatures for fallback tests
drklee3 815415c
fix: Resolve use of type assertions, enforcing types
drklee3 7ec0ffe
refactor: Rename unused params in test cases
drklee3 4df0c17
refactor: Dynamic generation basic ABI test cases
drklee3 cd15cde
refactor: Resolve ABI disabled types & errors
drklee3 0f248d2
refactor: Only test receive, fallback funcs when available
drklee3 8a90bbc
lint: Ignore solhint issues for mock contracts
drklee3 1d98340
refactor: Remove unused empty ContractTestCase generic brackets
drklee3 70f72d8
chore: Disable chai assertion error truncation
drklee3 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev
Previous commit
chore: Disable chai assertion error truncation
Long errors are truncated and difficult to determine the issue otherwise
commit 70f72d8c6028d63d6366d55f849f3d94d0f24212
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❤️ Idk why I didn't find this setting, so much nicer without any truncation