-
Notifications
You must be signed in to change notification settings - Fork 36
Restoration of the formatter for KeY files #3494
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Achieving auto-formatting for |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is no documentation / commenting at all.
b7dc229
to
d9a301b
Compare
@mattulbrich Looking in the test log shows, that not all KeY files in the repo are parsable anymore. |
CodeBuff could be interesting here: https://www.antlr.org/papers/codebuff.pdf |
This PR seems to also touch totally unrelated parts of the code. This is why it should not be merged as is. |
I only see the necessary changes, and a lot of changes that arise by the fact, that the main is running away (spotless indentation changes, etc.) |
7320163
to
97b2eda
Compare
I have added some javadoc to the Wiesler files. |
01b23cf
to
f090ee7
Compare
Formatter works now, but not on Windows. @mattulbrich |
key.core/src/test/java/de/uka/ilkd/key/proof/runallproofs/GenerateUnitTests.java
Outdated
Show resolved
Hide resolved
There is no documentation. Can we add a README on the subproject toplevel explaining what this is for and what to do, how to configure etc. |
Should it be part of the reformatting tasks? Would that not touch some gradle files in key.core? |
I wanted to keep the PR small. Normally, you want the formatter in spottless, but it is not obvious how todo it. I also fear the dependency when formatting requires compilation. |
Added a task |
afea601
to
62334b7
Compare
* minor cleanups
Archeology: In the back old days, we reformatted all our KeY files.
If you need to restore a branch before that time to bring it on the master, you should also reformat the KeY files before the merging.
This PR brings the formatter written by Wiesler.
The original MR was !614.
Currently unclear, whether we want to bring this on the main.
Has Sonarqube activated for evaluation reason