Skip to content

Cleanup: Removal of the write and read settings using Properties #3549

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

wadoon
Copy link
Member

@wadoon wadoon commented Feb 15, 2025

This PR removes the deprecated methods for readSettings(Properties) and writeSettings(Properties).

This will break old KeY files.

Consequences are a lot of dead code, and some simplifications in the UI.

"Show all Settings" is now tree-based instead of tables.

image

@wadoon wadoon enabled auto-merge February 15, 2025 00:36
@wadoon wadoon self-assigned this Feb 15, 2025
@wadoon wadoon added the 🛠 Maintenance Code quality and related things w/o functional changes label Feb 15, 2025
@wadoon wadoon added this to the v2.12.4 milestone Feb 15, 2025
@wadoon wadoon force-pushed the weigl/cleanup/settings branch from 4152355 to e66f87e Compare February 15, 2025 00:45
@wadoon
Copy link
Member Author

wadoon commented Feb 15, 2025

Question: Could it be that proof settings can changed by the proof replayer?

@wadoon wadoon force-pushed the weigl/cleanup/settings branch from d1a22ba to 94ac715 Compare February 20, 2025 20:51
@wadoon wadoon force-pushed the weigl/cleanup/settings branch from 94ac715 to 5d21584 Compare March 5, 2025 22:11
@wadoon wadoon force-pushed the weigl/cleanup/settings branch from 5d21584 to 593ec02 Compare March 31, 2025 15:28
@wadoon wadoon marked this pull request as draft March 31, 2025 15:28
auto-merge was automatically disabled March 31, 2025 15:28

Pull request was converted to draft

@wadoon wadoon force-pushed the weigl/cleanup/settings branch from 593ec02 to caf7b94 Compare April 4, 2025 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🛠 Maintenance Code quality and related things w/o functional changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant