Skip to content

Rewriter of old to new settings format. #3590

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Conversation

wadoon
Copy link
Member

@wadoon wadoon commented Apr 6, 2025

This PR brings a tool for rewriting the settings in KeY files to the new JSON-like format. A requirement to get rid of the old property-based interface.

Changes along the road:

  • The KeYLexer can be configured whether \proof is also treated as EOF or not. In normal mode, the lexer stops at \proof so that the s-expr of the proof are not going through the parser.

Plan

  • Rewrite all KeY files

Type of pull request

  • Refactoring (behaviour should not change or only minimally change)
  • New feature (non-breaking change which adds functionality)

Ensuring quality

  • Before overwriting the file, the reformater checks the parsebility.

@wadoon wadoon requested a review from mattulbrich April 6, 2025 18:39
@wadoon wadoon self-assigned this Apr 6, 2025
@wadoon wadoon added the 🛠 Maintenance Code quality and related things w/o functional changes label Apr 6, 2025
@wadoon wadoon force-pushed the weigl/settingsrewriter branch 2 times, most recently from 4ecc7ac to 0e7e297 Compare April 17, 2025 13:11
@mattulbrich
Copy link
Member

Agreed during meeting: Move to scripts directory. Reminder: When removing from the parser, make sure to give a descriptive error message.

@wadoon wadoon force-pushed the weigl/settingsrewriter branch from 0e7e297 to 5a0ef3e Compare May 27, 2025 21:28
@wadoon wadoon force-pushed the weigl/settingsrewriter branch from 5a0ef3e to 812cd8d Compare June 6, 2025 22:40
@wadoon wadoon marked this pull request as draft June 6, 2025 22:41
@wadoon wadoon force-pushed the weigl/settingsrewriter branch 2 times, most recently from bd87b0f to 6aed5af Compare June 14, 2025 09:51
@wadoon wadoon force-pushed the weigl/settingsrewriter branch from 6aed5af to 68426b5 Compare June 29, 2025 22:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🛠 Maintenance Code quality and related things w/o functional changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants