Skip to content

module-info.java, 2nd attempt #3623

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 21 commits into
base: main
Choose a base branch
from
Open

module-info.java, 2nd attempt #3623

wants to merge 21 commits into from

Conversation

wadoon
Copy link
Member

@wadoon wadoon commented Jun 19, 2025

Second run for module-info in KeY after the drop of ST4. Builds-upon #3621, should merged afterwards.

This pull request adds module support in KeY by adding module-info.java and doing the necessary stuff. There are three main issues with modules in KeY:

  • clashing Java packages (packages are sealed)
    (solved by renaming some packages)

  • Docking Frames is not-modularized
    (Baked a new version, with renamed packages. **This version is on central snapshot repo, and should then be deployed to Maven central)

  • Caching extension in wrong service file

Additional:

  • Removal of ANTLR2+3 from KeY.

Hint:

  • Isabelle translation added a Scala library, which breaks the Java module convention, but it seems not to break the JVM module system (invalid module name).

Type of pull request

  • Refactoring (behaviour should not change or only minimally change)

@wadoon wadoon self-assigned this Jun 19, 2025
@wadoon wadoon added this to the v2.12.4 milestone Jun 19, 2025
@wadoon wadoon changed the title weigl/module module-info.java, 2nd attempt Jun 20, 2025
@wadoon wadoon force-pushed the weigl/module branch 2 times, most recently from ef482fd to a10effd Compare June 29, 2025 22:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants