fix: prevent extra padding in centered header cells when no buttons are displayed#502
Merged
alessandrojcm merged 2 commits intov2from Mar 14, 2025
Merged
fix: prevent extra padding in centered header cells when no buttons are displayed#502alessandrojcm merged 2 commits intov2from
alessandrojcm merged 2 commits intov2from
Conversation
Closed
1 task
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes issue #414 where header cells with
align: 'center'were not properly centered due to extra padding being added even when no buttons were displayed.Problem
The issue was in the
MRT_TableHeadCellcomponent, where padding was being added based on theshowColumnButtonscondition, even when there were no actual buttons or actions to display. This caused centered header cells to appear off-center compared to body cells with the same alignment.Solution
Modified the
headerPLcalculation to only add padding when there are actual buttons or actions to display:closes #414