Fix encoding issue in buffer

Keyang · Oct 7, 2017 · 34df32c · ronkorving · Dec 7, 2017 · Keyang
1 parent 6099161
commit 34df32c
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 4 deletions.
diff --git a/libs/core/Converter.js b/libs/core/Converter.js
@@ -89,9 +89,10 @@ function emitDone(conv) {
 
 
 function bufFromString(str) {
+  var length=Buffer.byteLength(str);
   var buffer = Buffer.allocUnsafe
-    ? Buffer.allocUnsafe(str.length)
-    : new Buffer(str.length);
+    ? Buffer.allocUnsafe(length)
+    : new Buffer(length);
   buffer.write(str);
   return buffer;
 }
@@ -530,7 +531,9 @@ Converter.prototype.transf = function (func) {
 
 Converter.prototype.fromString = function (csvString, cb) {
   if (typeof csvString !== "string") {
-    return cb(new Error("Passed CSV Data is not a string."));
+    if (cb && typeof cb ==="function"){
+      return cb(new Error("Passed CSV Data is not a string."));
+    }
   }
   if (cb && typeof cb === "function") {
     this.wrapCallback(cb, function () {

diff --git a/package.json b/package.json
@@ -244,7 +244,7 @@
       "hireable": null
     }
   ],
-  "version": "1.1.8",
+  "version": "1.1.9",
   "keywords": [
     "csv",
     "csv parser",