-
Notifications
You must be signed in to change notification settings - Fork 0
Ab#71912 #11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: release-1.1
Are you sure you want to change the base?
Ab#71912 #11
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR modernizes the Alteon Load Balancer orchestrator extension by
- Integrating PAM secret resolution into the Inventory and Management jobs
- Upgrading the project to multi‐target .NET (net6.0 and net8.0) and bumping dependencies
- Overhauling documentation and updating the CI workflow
Reviewed Changes
Copilot reviewed 12 out of 25 changed files in this pull request and generated no comments.
Show a summary per file
File | Description |
---|---|
readme_source.md | Removed legacy setup guide that is now covered in README.md and docsource |
integration-manifest.json | Added release_dir /release_project , unified store_types schema, and enabled PAM support |
docsource/content.md | Added top-level overview for doctool documentation |
docsource/alteonlb.md | Created placeholder for specific AlteonLB doc |
alteon-orchestrator/alteon-orchestrator.csproj | Switched from netstandard2.0 to net6.0/net8.0, disabled ImplicitUsings, bumped package versions |
alteon-orchestrator/PAMUtilities.cs | Introduced helper to resolve secrets via IPAMSecretResolver |
alteon-orchestrator/Jobs/Management.cs | Injected IPAMSecretResolver , updated InitializeStore to use PAMUtilities |
alteon-orchestrator/Jobs/JobBase.cs | Added _resolver field, changed InitializeStore signatures, and inadvertently cleared ExtensionName |
alteon-orchestrator/Jobs/Inventory.cs | Injected IPAMSecretResolver , updated InitializeStore to use PAMUtilities |
README.md | Completely restructured with badges, CLI/portal instructions, and detailed store‐type creation guide |
CHANGELOG.md | Added version 1.1.0 entry for dual build and documentation tooling |
.github/workflows/keyfactor-starter-workflow.yml | Renamed workflow, streamlined job definitions, and added doctool/scan secrets |
Comments suppressed due to low confidence (6)
docsource/alteonlb.md:1
- [nitpick] This file only contains a header and no integration details. Either populate it with relevant content or remove it if it’s not required.
## Overview
README.md:43
- [nitpick] The sentence starts with 'The for...' and lacks proper punctuation, making it confusing. Consider rephrasing to: 'For the Alteon Load Balancer Universal Orchestrator extension, if you have a support issue, please open a support ticket...'.
The for Alteon Load Balancer Universal Orchestrator extension If you have a support issue, please open a support ticket by either contacting your Keyfactor representative or via the Keyfactor Support Portal at https://support.keyfactor.com.
.github/workflows/keyfactor-starter-workflow.yml:14
- The
uses
reference points to a non-standard path and branch ('screenshots') that likely doesn’t exist. Update it to the correct action repository and ref (e.g.,keyfactor/actions/starter.yml@main
).
uses: keyfactor/actions/.github/workflows/starter.yml@screenshots
alteon-orchestrator/Jobs/JobBase.cs:23
- The
ExtensionName
property was cleared, which will likely break the orchestrator’s registration of this extension. It should be set back to "AlteonLB" or restored dynamically.
public string ExtensionName => "";
alteon-orchestrator/Jobs/Management.cs:37
- Adding only a parameterized constructor may prevent the orchestrator from instantiating this job extension via its default constructor. Consider providing a parameterless constructor or using a DI-friendly mechanism.
public Management(IPAMSecretResolver resolver)
alteon-orchestrator/Jobs/Inventory.cs:30
- Similar to Management, this constructor requires a resolver parameter and may break default instantiation of the IInventoryJobExtension. Add a parameterless overload or adjust injection to maintain compatibility.
public Inventory(IPAMSecretResolver resolver)
No description provided.