Store type refresh #275
Open
Store type refresh #275
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Release 1.8.0
Signed-off-by: spbsoluble <[email protected]>
Signed-off-by: spbsoluble <[email protected]>
Signed-off-by: spbsoluble <[email protected]>
…of `v3` Signed-off-by: spbsoluble <[email protected]>
Signed-off-by: spbsoluble <[email protected]>
Signed-off-by: spbsoluble <[email protected]>
Signed-off-by: spbsoluble <[email protected]>
Signed-off-by: spbsoluble <[email protected]>
There was a problem hiding this comment.
Pull Request Overview
This is a "Store type refresh" PR that primarily updates the application version to 1.8.1 and refreshes store type definitions with the latest configuration data.
- Updates version number from 1.7.0 to 1.8.1 across version files
- Refreshes store type definitions with new and updated configurations for various certificate store types (AWS ACM v3, Airlock WAF, etc.)
- Updates dependency versions in go.mod and documentation timestamps
Reviewed Changes
Copilot reviewed 66 out of 67 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| pkg/version/version.go | Updates version from 1.7.0 to 1.8.1 |
| store_types.json | Major refresh of store type definitions with new store types and updated configurations |
| go.mod | Updates various dependency versions including Azure SDK and crypto packages |
| cmd/store_types.json | Identical update to store type definitions as main file |
| docs/*.md | Updates auto-generated documentation timestamps from June to July |
| cmd/storeTypes.go | Adds call to informDebug(false) during initialization |
| cmd/helpers.go | Improves debug logging by disabling logs when debug mode is off |
| CHANGELOG.md | Documents changes for v1.8.1 release |
| .github/workflows/update-stores.yml | Updates action versions from v3 to v4 |
Comments suppressed due to low confidence (3)
| "DefaultValue": "https://***/oauth2/default/v1/token", | ||
| "Required": false, | ||
| "IsPAMEligible": false, | ||
| "Description": "An optional parameter sts:ExternalId to pass with Assume Role calls" |
There was a problem hiding this comment.
The description for OAuthUrl parameter is incorrect. It describes an sts:ExternalId parameter, but this field is for OAuth URL configuration.
Suggested change
| "Description": "An optional parameter sts:ExternalId to pass with Assume Role calls" | |
| "Description": "The URL of the OAuth 2.0 token endpoint used to obtain access tokens." |
Copilot uses AI. Check for mistakes.
| @@ -1633,7 +1834,7 @@ | |||
| "Capability": "F5-CA-REST", | |||
| "ServerRequired": true, | |||
| "ClientMachineDescription": "The server name or IP Address for the F5 device.", | |||
| "StorePathDescription": "Enter the name of the partition on the F5 device you wish to manage. This value is case sensitive, so if the partition name is \"Common\", it must be entered as \"Common\" and not \"common\",", | |||
| "StorePathDescription": "Enter the name of the partition followed by the name of the bundle separated by a / (i.e. Common/BundleName). This value is case sensitive, so if the partition name is \"Common/BundleName\", it must be entered as \"Common/BundleName\" and not \"common/bundlename\",", | |||
There was a problem hiding this comment.
The description has a trailing comma at the end which appears to be unintentional.
Suggested change
| "StorePathDescription": "Enter the name of the partition followed by the name of the bundle separated by a / (i.e. Common/BundleName). This value is case sensitive, so if the partition name is \"Common/BundleName\", it must be entered as \"Common/BundleName\" and not \"common/bundlename\",", | |
| "StorePathDescription": "Enter the name of the partition followed by the name of the bundle separated by a / (i.e. Common/BundleName). This value is case sensitive, so if the partition name is \"Common/BundleName\", it must be entered as \"Common/BundleName\" and not \"common/bundlename\".", |
Copilot uses AI. Check for mistakes.
| @@ -1818,7 +2028,7 @@ | |||
| "DependsOn": "", | |||
| "DefaultValue": "false", | |||
| "Required": true, | |||
| "Description": "Select this if you wish to use F5's token authentiation instead of basic authentication for all API requests. If you choose not to add this custom field, the default value of False will be assumed and basic authentication will be used for all API requests for all jobs. Setting this value to True will enable an initial basic authenticated request to acquire an authentication token, which will then be used for all subsequent API requests." | |||
| "Description": "Select this if you wish to use F5's token authentication instead of basic authentication for all API requests. If you choose not to add this custom field, the default value of False will be assumed and basic authentication will be used for all API requests for all jobs. Setting this value to True will enable an initial basic authenticated request to acquire an authentication token, which will then be used for all subsequent API requests." | |||
There was a problem hiding this comment.
The word 'authentiation' in the original line was corrected to 'authentication', which is the proper spelling.
Copilot uses AI. Check for mistakes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.