Skip to content

Support multiple device groups in job properties #36

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 14 commits into
base: release-2.5
Choose a base branch
from

Conversation

irby
Copy link

@irby irby commented Jun 11, 2025

Solves #35

This PR has many things:

  • We now support job properties to specify multiple device groups in a semicolon delimited list.
  • Shifting the tests over to the IntegrationTests test suite. This makes it easier to run specific test cases, debug test cases, easily configure the inputs, and it no longer needs to make a Keyfactor Command request to generate a PFX certificate for testing.
  • Adds in unit tests for some of the codebase. Tests specific parts of code that were updated for this feature update.
  • There were some code parts that had fixed timeouts to wait out commit jobs. I've added in the ability to wait for a queued job to complete and validate the job was successful. This ensures that the commits we're making actually get propagated to the Palo Alto system (before, it was fire-and-forget).

@irby irby changed the base branch from main to release-2.5 June 12, 2025 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant