Remove JSON mode checkbox from EditorPage #2740
Open
+31
−36
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeremywiebe
approved these changes
Jul 30, 2025
Collaborator
jeremywiebe
left a comment
jeremywiebe
left a comment
There was a problem hiding this comment.
I was going to ask for changes because I thought we still needed to render the JSON switch/checkbox, but I see that's been migrated up into the new exercise chrome!
Good to go! Thanks for removing this bit of now-unused code!
… to onChange callback of EditorPage. This was almost certainly a bug. Nothing in webapp was using this behavior, but if it had been, extra jsonMode properties would have been written into assessmentItem data
benchristel
force-pushed
the
benc/remove-json-mode-toggle
branch
from
0a216f2 to
39fb3c8
Compare
Contributor
🗄️ Schema Change: No Changes ✅ |
Contributor
🛠️ Item Splitting: No Changes ✅ |
Contributor
|
Size Change: -56 B (-0.01%) Total Size: 496 kB
ℹ️ View Unchanged
|
Contributor
npm Snapshot: PublishedGood news!! We've packaged up the latest commit from this PR (39fb3c8) and published it to npm. You Example: pnpm add @khanacademy/perseus@PR2740If you are working in Khan Academy's frontend, you can run the below command. ./dev/tools/bump_perseus_version.ts -t PR2740If you are working in Khan Academy's webapp, you can run the below command. ./dev/tools/bump_perseus_version.js -t PR2740 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While investigating how we might parse/migrate PerseusItem data before emitting
it from the editor, I noticed this weird
jsonModeparam in theonChangecallback. Nothing in webapp seems to be using it, so I'd just as soon remove
it. It's a footgun.
Issue: none
Test plan:
View the EditorPage stories.