Do not land - needs to wait for AX pilot [Image] | (CX) | Add issues panel warning for long alt text #2921
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ing message about alt text length, and encourage the use of long description if alt text is too long
…ng for long alt text Adding the long alt text warning message to the perseus linter. This will make it show up in the issues panel, and it will show the red dot of doom. Issue: https://khanacademy.atlassian.net/browse/LEMS-3379 Test plan: `pnpm jest packages/perseus-linter/src/rules/image-widget.test.ts` Storybook - `?path=/docs/widgets-image-editor-demo--docs#populated-within-editor-page`
…ssues panel warning for long alt text
Contributor
🗄️ Schema Change: No Changes ✅ |
Contributor
🛠️ Item Splitting: No Changes ✅ |
Contributor
|
Size Change: +87 B (+0.02%) Total Size: 493 kB
ℹ️ View Unchanged
|
Contributor
npm Snapshot: PublishedGood news!! We've packaged up the latest commit from this PR (c4cf9ba) and published it to npm. You Example: pnpm add @khanacademy/perseus@PR2921If you are working in Khan Academy's frontend, you can run the below command. ./dev/tools/bump_perseus_version.ts -t PR2921If you are working in Khan Academy's webapp, you can run the below command. ./dev/tools/bump_perseus_version.js -t PR2921 |
Contributor
Author
|
Putting the video in a new comment rather than the PR description so the checks don't rerun. Screen.Recording.2025-09-24.at.3.28.17.PM.mov |
catandthemachines
approved these changes
Sep 24, 2025
Member
catandthemachines
left a comment
catandthemachines
left a comment
There was a problem hiding this comment.
Looks great to me! Thank you @nishasy 😊
nishasy
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Adding the long alt text warning message to the perseus linter.
This will make it show up in the issues panel, and it will show
the red dot of doom.
Issue: https://khanacademy.atlassian.net/browse/LEMS-3379
Test plan:
pnpm jest packages/perseus-linter/src/rules/image-widget.test.tsStorybook
?path=/docs/widgets-image-editor-demo--docs#populated-within-editor-page