Skip to content

Commit

Permalink
GitHub CI: Adjust presets for uwp builds, disable 32-bit arm
Browse files Browse the repository at this point in the history
Runners apparently now default to Windows SDK 10.0.26100.0,
but are missing the corresponding ARM64 compilers.
We can force an older Windows SDK, but CMake mysteriously
fails to find WindowsApp.lib on arm (32 bit) then.
  • Loading branch information
rpavlik committed Nov 27, 2024
1 parent 20a38ab commit 0c46380
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 6 deletions.
8 changes: 4 additions & 4 deletions .github/scripts/CMakePresets.json
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@
"inherits": "win32",
"cacheVariables": {
"CMAKE_SYSTEM_NAME": "WindowsStore",
"CMAKE_SYSTEM_VERSION": "10.0"
"CMAKE_SYSTEM_VERSION": "10.0.22000.0"
}
},
{
Expand All @@ -45,7 +45,7 @@
"inherits": "x64",
"cacheVariables": {
"CMAKE_SYSTEM_NAME": "WindowsStore",
"CMAKE_SYSTEM_VERSION": "10.0"
"CMAKE_SYSTEM_VERSION": "10.0.22000.0"
}
},
{
Expand All @@ -54,7 +54,7 @@
"architecture": "ARM",
"cacheVariables": {
"CMAKE_SYSTEM_NAME": "WindowsStore",
"CMAKE_SYSTEM_VERSION": "10.0"
"CMAKE_SYSTEM_VERSION": "10.0.22000.0"
}
},
{
Expand All @@ -63,7 +63,7 @@
"architecture": "ARM64",
"cacheVariables": {
"CMAKE_SYSTEM_NAME": "WindowsStore",
"CMAKE_SYSTEM_VERSION": "10.0"
"CMAKE_SYSTEM_VERSION": "10.0.22000.0"
}
},
{
Expand Down
2 changes: 1 addition & 1 deletion .github/scripts/shared.py
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@

VS_VERSION = "Visual Studio 17 2022"

PLATFORMS = ("Win32", "x64", "ARM", "ARM64")
PLATFORMS = ("Win32", "x64", "ARM64") # "ARM",

TRUE_FALSE = (True, False)

Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/windows-matrix.yml
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ jobs:
- win32_uwp
- x64_uwp
- arm64_uwp
- arm_uwp
# - arm_uwp

uses: "./.github/workflows/msvc-build-preset.yml"
with:
Expand Down

0 comments on commit 0c46380

Please sign in to comment.