Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport to 14] Fix reverse translation of non-constant values of OpCompositeConstruct #2299

Conversation

vmaksimo
Copy link
Contributor

@vmaksimo vmaksimo commented Jan 10, 2024

This patch introduces a way to use runtime values for structure fields, array and vector types.

Original changes: a6f017a and 4db768c

vmaksimo and others added 2 commits January 10, 2024 03:09
KhronosGroup#2256)

This patch introduces a way to use runtime values for structure fields.

Co-authored-by: Arvind Sudarsanam <[email protected]>
…t pt.2 (KhronosGroup#2296)

This patch introduces a way to use runtime values for array and vector
types. It continues KhronosGroup#2256
@vmaksimo vmaksimo requested a review from MrSidims January 10, 2024 11:15
@vmaksimo vmaksimo marked this pull request as draft January 10, 2024 12:12
@vmaksimo vmaksimo marked this pull request as ready for review January 12, 2024 16:00
@asudarsa
Copy link
Contributor

Build failure has been reported here: #2284

Copy link
Contributor

@asudarsa asudarsa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Not sure if we can commit without someone resolving the windows build fail. Surely seems not related, so I am approving this.

@MrSidims
Copy link
Contributor

Restarting CI to see if the build failure is fixed

@MrSidims MrSidims closed this Jan 23, 2024
@MrSidims MrSidims reopened this Jan 23, 2024
@MrSidims MrSidims merged commit 582a302 into KhronosGroup:llvm_release_140 Jan 23, 2024
16 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants