[DebugInfo] Continue fixing translation of debug info for mem2reged vars #3129
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
// TODO: update description
There was a problem hiding this comment.
Pull Request Overview
This PR refines the filtering logic in the getVariableInsertionPoint() function to better handle debug instructions when translating debug info for mem2reged variables.
- Refactored the lambda to use early returns for greater clarity.
- Added explicit filtering for debug extension instructions matching specific op codes.
- Updated conditions to ensure that debug instructions which could describe OpVariable are properly skipped.
Files not reviewed (1)
- test/DebugInfo/mem2reged_local_var_func_start.ll: Language not supported
MrSidims
reviewed
Apr 25, 2025
Comment on lines
105
to
108
| if ((ExtSetKind == SPIRVEIS_Debug || | ||
| ExtSetKind == SPIRVEIS_OpenCL_DebugInfo_100 || | ||
| ExtSetKind == SPIRVEIS_NonSemantic_Shader_DebugInfo_100 || | ||
| ExtSetKind == SPIRVEIS_NonSemantic_Shader_DebugInfo_200) && |
There was a problem hiding this comment.
nit: I feel like checks for ExtSetKind here is redundant and checking for the ExtOp is enough.
There was a problem hiding this comment.
And TODO for me: push an update to DebugInfo specs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refine the filtering logic in the
getVariableInsertionPoint()function to better handle debug info for mem2reged variables - allow debug instructions that could describeOpVariableto be in the first block in the function as well.