Added test files opencl_version_metadata.ll and progvar_prog_scope_uninit.ll #3318
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
-- Ported from opencl subdirectory of llvm project repo
MrSidims
reviewed
Aug 14, 2025
| @@ -0,0 +1,48 @@ | |||
| ; RUN: split-file %s %t | |||
There was a problem hiding this comment.
this test both supersets and subset of existing tests. For example we also have here already transcoding/spirvSourceCL2.0.ll and multi_md.ll (and may be more). If we are about to merge this PR - we should:
a. remove transcoding/spirvSourceCL2.0.ll
b. check, what multi_md.ll does and either incorporate in this test or decide to leave multi_md.ll as a stand alone test
Again, there might be more tests
There was a problem hiding this comment.
I think i can maybe delete this test as the spirvSourceCLCXX.ll serves the purpose of this test.
| @@ -0,0 +1,62 @@ | |||
| ; RUN: llvm-as %s -o %t.bc | |||
There was a problem hiding this comment.
Not sure if I understand purpose of this test, is it for zeroinitialized GVs?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.