[Backport] Two backports from 17 to 16 #3401
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original message: Add ComponentTypeInterpretation for joint matrix type (KhronosGroup#1835) It specifies how to interpret 'Component Type' when components of a joint matrix are storages for values of different types, for example float for TF32, unsigned short for bfloat16. At this point only tf32 type interpretation is added during SPIR-V generation. Adding it to bf16 is a breaking change and requires adaptation across drivers. Spec update: intel/llvm#8175 Signed-off-by: Sidorov, Dmitry [email protected]
Original Message: Start preparing for TypeJointMatrixINTEL switch (KhronosGroup#1935) The patch adds TypeJointMatrixINTELv2 which maps to new type OpCode 6184. Under new OpCode matrix type no longer has Layout parameter. The patch also moved 'scope' to optional matrix muladd instruction. The changes are done only in the consumer part to prepare the switch and make E2E switch backward compatible by preparing consumers ahead of time. Unfortunately there is no way to add a test foe this unless it's binary test, but it seems to be a bit unsafe to add this, so the patch was tested locally. Spec change: intel/llvm#8175 Signed-off-by: Sidorov, Dmitry <[email protected]>
bokrzesi
force-pushed
the
translator_fix_jm1
branch
from
ad6fd4c to
1e80af6
Compare
MrSidims
reviewed
Oct 20, 2025
| case OpTypeSampler: | ||
| return SPIRV_SAMPLER_T_ADDR_SPACE; | ||
| case internal::OpTypeJointMatrixINTEL: | ||
| case internal::OpTypeJointMatrixINTELv2: |
There was a problem hiding this comment.
@bokrzesi could you please elaborate, why do we need these backports? They were not done, because our base extension for sycl::joint matrices is SPV_KHR_cooperative_matrix. Hence Intel's version for this functionality no longer contain joint matrix type and other common functionality.
There was a problem hiding this comment.
Hi, I'm trying to figure out what needs to be backported
I need this (lib/SPIRV/SPIRVReader.cpp)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.