Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmake: Add 'ARCHIVE DESTINATION' for static library target #270

Merged
merged 1 commit into from
Jul 2, 2024
Merged

cmake: Add 'ARCHIVE DESTINATION' for static library target #270

merged 1 commit into from
Jul 2, 2024

Conversation

fabian-lunarg
Copy link
Contributor

trying to compile as static lib, using android and older cmake 3.10 we ran into this error:

SPIRV-Reflect/CMakeLists.txt:116 (install):
        install TARGETS given no ARCHIVE DESTINATION for static library target
        "spirv-reflect-static".

@CLAassistant
Copy link

CLAassistant commented Jul 2, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@fabian-lunarg fabian-lunarg force-pushed the fabian_lunarg_minor_cmake_fix branch from 9571f46 to 839801a Compare July 2, 2024 14:01
charles-lunarg
charles-lunarg approved these changes Jul 2, 2024
View reviewed changes
Copy link

@charles-lunarg charles-lunarg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unblock development upstream.

@cassiebeckley cassiebeckley merged commit fa71fe8 into KhronosGroup:main Jul 2, 2024
5 checks passed
@fabian-lunarg
Copy link
Contributor Author

thank you @cassiebeckley!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@charles-lunarg charles-lunarg charles-lunarg approved these changes

@cassiebeckley cassiebeckley cassiebeckley approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@fabian-lunarg @CLAassistant @cassiebeckley @charles-lunarg