Skip to content

Conversation

@makkarpov
Copy link

@makkarpov makkarpov commented Jul 25, 2024

This PR adds support for building SPIRV-Reflect as a shared library.

Sure enough, this library is not a perfect candidate to be shared (i.e. stack-allocated structs without any kind of layout or size stability guarantees), but at least this PR makes library usable via FFI interface from languages like Java.

@CLAassistant
Copy link

CLAassistant commented Jul 25, 2024

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@makkarpov makkarpov force-pushed the main branch 3 times, most recently from 7b62fde to 638331b Compare July 25, 2024 15:01
Copy link
Contributor

@spencer-lunarg spencer-lunarg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - @chaoticbob mentioned how we should add a blurb to the README.md to mention this is possible and which cmake options to set

@makkarpov makkarpov marked this pull request as draft July 26, 2024 01:33
@makkarpov
Copy link
Author

makkarpov commented Jul 26, 2024

Ok, I will add mentions in README.md that shared library build is possible.

Also, to be on the safe side, I will also perform DLL testing on Windows with actual application. It should work (GCC cross-compilation succeeded, all exports are present), but it's better to check.

@makkarpov makkarpov marked this pull request as ready for review July 27, 2024 23:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants