Fix undefined enums #286
Merged
Fix undefined enums #286
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are a few places where an enum value is purpoposly getting a value that is not one of the enum values. This is causing a problem when testing. I have a quick fix to make those values `int` instead of the enum type. The variables could contain `-1` as a special value to indicate that no storage class or builtin is used. We cannot change the enum class to add `-1` because it is defined in spirv headers.
Co-authored-by: Spencer Fricke <[email protected]>
cassiebeckley
approved these changes
Nov 11, 2024
spencer-lunarg
approved these changes
Nov 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are a few places where an enum value is purpoposly getting a value
that is not one of the enum values. This is causing a problem when
testing. I have a quick fix to make those values
intinstead of theenum type.
The variables could contain
-1as a special value to indicate that nostorage class or builtin is used. We cannot change the enum class to add
-1because it is defined in spirv headers.