Skip to content

Conversation

@danginsburg
Copy link
Contributor

@danginsburg danginsburg commented Dec 3, 2024

closes #287 - caused by assumption that PhysicalStorageBuffers will always point to structs. They can point to plain data types.

danginsburg added 2 commits December 3, 2024 09:54
…ysicalStorageBuffers will always point to structs. They can point to plain data types.
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


danginsburg seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@spencer-lunarg spencer-lunarg changed the title Fixes issue #287 - fix crash caused by assumption that PhysicalStorag… Fixes issue #287 - fix crash Dec 4, 2024
@danginsburg
Copy link
Contributor Author

Closing in favor of #289

@danginsburg danginsburg closed this Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Reflection of shader with pointer to POD (not a struct) crashes

2 participants