Check if parent is actually a runtime array#306
Open
spencer-lunarg wants to merge 1 commit intoKhronosGroup:mainfrom
Open
Check if parent is actually a runtime array#306spencer-lunarg wants to merge 1 commit intoKhronosGroup:mainfrom
spencer-lunarg wants to merge 1 commit intoKhronosGroup:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an attempt to solve #304
It seems there was an assumption all
StorageBufferwere runtime array, which is not true (see newstorage_buffer_runtime.glsltest)I add what seems like the correct fix, but now it feels like the output is wrong (but like different wrong) so might need to figure out why our size logic seems incorrect here
cc @chaoticbob for ideas/thoughts/concerns/nostalgia