Skip to content

Added support for multiple entrypoints for CLI yaml print #316

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

Added support for multiple entrypoints for CLI yaml print #316

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
be14602
Fixed all_interface_variables for multiple entrypoints
Luna5ama Jul 3, 2025
86fade4
Added support for multiple entrypoints for CLI yaml print
Luna5ama Jul 3, 2025
06f8a47
Removed older stuff that only works with 1 entrypoint from print yaml
Luna5ama Jul 3, 2025
f18bd04
Yaml print used descriptor binding index
Luna5ama Jul 3, 2025
393bb57
Fixed missing type descriptions from other entrypoints
Luna5ama Jul 4, 2025
18cf482
Removed interface_variables printing because we only cared input and …
Luna5ama Jul 4, 2025
5c91c09
Regenerated golden yaml files
Luna5ama Jul 4, 2025
6b938b5
Renerated golden yaml on Linux
Luna5ama Jul 4, 2025
2adabda
Fixed used push constant index prefix
Luna5ama Jul 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion tests/user_type/byte_address_buffer_0.spv.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,7 @@ all_descriptor_bindings:
accessed: 1
uav_counter_id: 4294967295
uav_counter_binding:
ByteAddressBuffer offsets: [13, 5, 11, 4]
ByteAddressBuffer offsets: [4, 5, 11, 13]
Copy link
Contributor Author

@Luna5ama Luna5ama Jul 4, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For whatever reason, the ordering is messed up on Windows with MSVC. It was supposed to be sorted. But that would be another issue and PR. There is already #307 for this.
https://github.com/KhronosGroup/SPIRV-Reflect/blob/main/spirv_reflect.c#L3669-L3674

type_description: *td1
word_offset: { binding: 129, set: 125 }
user_type: ByteAddressBuffer
Expand Down
2 changes: 1 addition & 1 deletion tests/user_type/byte_address_buffer_1.spv.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -274,7 +274,7 @@ all_descriptor_bindings:
accessed: 1
uav_counter_id: 4294967295
uav_counter_binding:
ByteAddressBuffer offsets: [2, 1]
ByteAddressBuffer offsets: [1, 2]
type_description: *td5
word_offset: { binding: 112, set: 108 }
user_type: ByteAddressBuffer
Expand Down
2 changes: 1 addition & 1 deletion tests/user_type/rw_byte_address_buffer.spv.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,7 @@ all_descriptor_bindings:
accessed: 1
uav_counter_id: 4294967295
uav_counter_binding:
ByteAddressBuffer offsets: [13, 5, 11, 4]
ByteAddressBuffer offsets: [4, 5, 11, 13]
type_description: *td1
word_offset: { binding: 130, set: 126 }
user_type: RWByteAddressBuffer
Expand Down
Loading