Avoid bleeding async exceptions between cases in event tests #1155
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds a event::wait_and_throw to the case checking that event::wait() does not consume asynchronous exceptions. This is to avoid the unconsumed exception to bleed into other test cases in implementations that consume such exceptions when consuming other unconsumed exceptions. Signed-off-by: Larsen, Steffen <[email protected]>
KornevNikita
added a commit
to KornevNikita/llvm
that referenced
this pull request
Nov 10, 2025
KhronosGroup/SYCL-CTS#1155 should fix this. Disabling until the patch is merged.
sarnex
pushed a commit
to intel/llvm
that referenced
this pull request
Nov 10, 2025
KhronosGroup/SYCL-CTS#1155 should fix this. Disabling until the patch is merged.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds a event::wait_and_throw to the case checking that event::wait() does not consume asynchronous exceptions. This is to avoid the unconsumed exception from bleeding into other test cases in implementations that consume such exceptions when consuming other unconsumed exceptions.