Derivate subgroup fix #442
Closed
+12
−12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For the tests that need subgroup ops, use the existing subgroups helper, rather than open-coding the same checks.
Some of these tests require subgroup ops support, but didn't bother checking whether they were supported. Add this missing checks.
|
|
Contributor
Tested in our MesaCI. |
Contributor
|
We are currently checking and reviewing this in Khronos CI. |
lordalcol
approved these changes
Mar 5, 2024
Contributor
lordalcol
left a comment
lordalcol
left a comment
There was a problem hiding this comment.
The changes in these two commits are already present in main.
Contributor
|
This is fixed as far as I know. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add missing checks for subgroup support. Fixes
dEQP-VK.glsl.derivate.*on devices which do not supportVK_SUBGROUP_FEATURE_QUAD_BIT