-
Notifications
You must be signed in to change notification settings - Fork 79
Fix missing DGG license #248
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
This looks "OK" for me insofar that it follows the pattern of other licenses. But I'm starting to question that pattern in #253 (somewhat unrelated to this PR, and probably to be dicussed independently) |
|
As discussed in #253 : The values of the
No strong preference, just laying out options. |
|
@javagl I don't feel, let's say, legally qualified to fix licensing-related code beyond simple fixes like this PR, so I won't do option 3 myself. If the license stuff needs restructuring, that should be done by someone who knows this area best. |
|
These seem like GitHub formatting issues to me. It seems like treating the DGG company logo as a trademark is the right way to go here. Content submitters like myself will need clear guidance on whatever the desired metadata formatting should be, once these issues are resolved. In the past, I just copied existing repo files, editing them to reflect the new content. So we should make sure existing repo files are properly formatted, and create clear submission guidelines. |
same here, and that may not be ideal, particularly in "non-standard-(license)-cases".
Yes, the submission guidelines have to be clarified - and this includes some aspects of the workflow. I started to ~"fix a few things" in #254 , but will have to read some of the metadata handling code more thoroughly. (Currently, low priority on my side, but will try to make some progress some time, and in the meantime, everybody can chime in...) EDIT: Didn't mean to close... |
This PR takes out a part of #237, just the fixes for the DGG license.
The Darmstadt Graphics Group GmbH legal mark license was missing validation in the PHP script. This caused the PHP script to produce invalid license text in the
.reuse/dep5file. This PR adds a case for this license, similar to the existing code for Cesium, Khronos, and UX3D. I also ran the PHP script locally.