Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support overriding input format in JS API #237

Merged
merged 1 commit into from
Oct 4, 2024
Merged

Support overriding input format in JS API #237

merged 1 commit into from
Oct 4, 2024

Conversation

lexaknyazev
Copy link
Member

Fixes #211.

@lexaknyazev lexaknyazev requested a review from emackey October 4, 2024 16:03
emackey
emackey approved these changes Oct 4, 2024
View reviewed changes
Copy link
Member

@emackey emackey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't do any live testing of this, but the code looks good.

@lexaknyazev lexaknyazev merged commit 0c697d5 into KhronosGroup:main Oct 4, 2024
2 checks passed
@lexaknyazev lexaknyazev deleted the format-override branch October 4, 2024 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emackey emackey emackey approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

npm version gltf-validator is not able to detect glb with GLB_INVALID_MAGIC error
2 participants
@lexaknyazev @emackey