Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version 2.0.0-dev.3.10 #240

Merged
merged 2 commits into from
Oct 22, 2024
Merged

Conversation

lexaknyazev
Copy link
Member

2.0.0-dev.3.10

New Features

  • Added support for KHR_materials_anisotropy extension.

    • Added KHR_MATERIALS_ANISOTROPY_ANISOTROPY_TEXTURE_TEXCOORD validation warning.
  • Added support for KHR_materials_dispersion extension.

    • Added KHR_MATERIALS_DISPERSION_NO_VOLUME validation warning.
  • Added new tangent space validations: MESH_PRIMITIVE_NO_TANGENT_SPACE validation error and MESH_PRIMITIVE_GENERATED_TANGENT_SPACE validation warning.

  • Added new KHR_MATERIALS_CLEARCOAT_CLEARCOAT_NORMAL_TEXTURE_TEXCOORD validation warning.

  • Added partial support for the KHR_animation_pointer extension.

    • Added new KHR_ANIMATION_POINTER_ANIMATION_CHANNEL_TARGET_NODE and KHR_ANIMATION_POINTER_ANIMATION_CHANNEL_TARGET_PATH validation errors.
    • Added new INCOMPLETE_EXTENSION_SUPPORT validation info.
  • Web version now supports external resources in directories.

Changes

  • Removed UNRESERVED_EXTENSION_PREFIX validation warning.

  • Removed KHR_MATERIALS_IRIDESCENCE_THICKNESS_RANGE_INVALID validation error following the spec update.

Bugfixes

Integration updates

  • The validateBytes JS API function now supports a format validation option to bypass format detection and force GLB or glTF JSON explicitly.

  • Added an option to ignore all validation issues except those passed explicitly; supported in both JS API and YAML config file.

@lexaknyazev lexaknyazev requested a review from emackey October 21, 2024 13:11
Copy link
Member

@emackey emackey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested the NPM build of this with gltf-vscode, and everything seems good.

Mostly for my own reference: I had some odd issue possibly caused by leftover stuff in my dart cache. @lexaknyazev fixed it with the following suggestion:

  1. Remove the .dart_tool directory and the pubspec.lock file.
  2. Call dart pub cache clean --force
  3. Call dart pub get
  4. Try building again

(Edit: Come to think of it, I probably had Dart 3.x installed and did a pub get at some point prior to rolling back to Dart 2.19.6 and running pub-get again. That's probably the source of the cache contamination.)

I'm not sure what happened there but the tool is working well now. Looks good!

@lexaknyazev lexaknyazev requested a review from emackey October 21, 2024 21:52
@lexaknyazev
Copy link
Member Author

@emackey Updated the README with these steps and other useful information.

Copy link
Member

@emackey emackey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. One question below.

README.md Show resolved Hide resolved
@lexaknyazev lexaknyazev merged commit bcd52cc into KhronosGroup:main Oct 22, 2024
2 checks passed
@lexaknyazev lexaknyazev deleted the release-3.10 branch October 22, 2024 08:01
@emackey
Copy link
Member

emackey commented Oct 22, 2024

Published to NPM: https://www.npmjs.com/package/gltf-validator

/cc @donmccurdy @bghgary @elalish

@lexaknyazev
Copy link
Member Author

The live drag-n-drop tool has been updated.

@donmccurdy
Copy link
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants