Fix incorrect "Contradictory layout" link errors #3920
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
…re layouts when using multiple compilation units, input/output layouts don't need to be declared in every unit. In the same spirit as 6f723eb
Valentin-Sarthou
force-pushed
the
incorrect_link_errors
branch
from
bf80843 to
2c12a5e
Compare
Valentin-Sarthou
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
I've come across issues similar to #1516 and #3919 where "Contradictory layout" link errors are generated when using multiple compilation units and declaring a layout in only 1 compilation unit.
A similar fix was done in 6f723eb for tessellation input and output primitives.
But the issue was still present for the following layouts:
This PR attempts to fix all these remaining cases, and adds tests for each.