[CMake] Enforce oneMath dependecy during configuration #410
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently when trying to build the whole project using CMake without a oneMath install on the system, CMake will configure okay but then fail to find dependencies at build time. A better used experience would be to try detect oneMath at CMake configure time, and then skip the `oneMath_gemm` target with a warning if oneMath isn't found. If we really do want `oneMath` to be a dependency then this should be `find_package(oneMath REQUIRED)`, but that feels like it increases the barrier to entry for newcomers.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently when trying to build the whole project using CMake without a oneMath install on the system, CMake will configure okay but then fail to find dependencies at build time.
A better used experience would be to try detect oneMath at CMake configure time, and then skip the
oneMath_gemmtarget with a warning if oneMath isn't found.If we really do want
oneMathto be a dependency then this should befind_package(oneMath REQUIRED), but that feels like it increases the barrier to entry for newcomers.