Skip to content
This repository has been archived by the owner on Oct 2, 2020. It is now read-only.

Add Cherry MX kbd switch fp #2418

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add Cherry MX kbd switch fp #2418

wants to merge 1 commit into from

Conversation

perigoso
Copy link
Contributor

See #2416 and #2394

This PR Adds Cherry MX keyboard switch footprints, replacing some existing ones.

@perigoso perigoso mentioned this pull request Aug 25, 2020
Open
@perigoso perigoso changed the title Added Cherry MX kbd switch fp, replaced existing Add Cherry MX kbd switch fp Aug 25, 2020
@myfreescalewebpage myfreescalewebpage added Addition Adds new footprint to library Pending reviewer A pull request waiting for a reviewer labels Aug 25, 2020
@perigoso
Copy link
Contributor Author

So I had _NoSilk variants of footprints, because some people, including me, don't include silkscreen on the switch footprints for aesthetic reasons, but i was unaware that it was possible to hide it in bulk in pcbnew, so after some digging around and trying things out i came to this:

image

This is a good versatile solution, and i feel the _NoSilk variants don't make sense given this option, maybe it might not be immediately clear to people but still, any input?

original comment

@perigoso perigoso force-pushed the kbd-fp-rework-cherrymx branch from 52991cb to abd8caf Compare September 4, 2020 05:44
@perigoso
Copy link
Contributor Author

perigoso commented Sep 4, 2020

Generated footprints with kicad-footprint-generator.

image
image

@perigoso perigoso force-pushed the kbd-fp-rework-cherrymx branch from abd8caf to d0f8e6e Compare September 4, 2020 06:07
@perigoso perigoso force-pushed the kbd-fp-rework-cherrymx branch from d0f8e6e to 7dcb5ec Compare September 13, 2020 10:55
@perigoso
Copy link
Contributor Author

Re-generated footprints with kicad-footprint-generator after fixups.

@perigoso perigoso force-pushed the kbd-fp-rework-cherrymx branch from 7dcb5ec to fd4878a Compare September 13, 2020 11:34
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
Addition Adds new footprint to library Pending reviewer A pull request waiting for a reviewer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@perigoso @myfreescalewebpage